Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: use lower pcre limits #12350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/4858

Describe changes:

  • fuzz/detect: lower pcre limits for fuzzing

Because such rules cause timeouts on oss-fuzz and block other findings

Alternative to #12344

Reverts commit 378f678

oss-fuzz reproducer runs in 5 seconds now (timeout is like 30)

to avoid timeouts

instead of forbidding pcre signatures on stream

Ticket: 4858
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.23%. Comparing base (def22fa) to head (fc01539).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12350   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         912      912           
  Lines      257647   257637   -10     
=======================================
- Hits       214450   214444    -6     
+ Misses      43197    43193    -4     
Flag Coverage Δ
fuzzcorpus 61.25% <100.00%> (+0.04%) ⬆️
livemode 19.39% <ø> (-0.01%) ⬇️
pcap 44.43% <ø> (+0.03%) ⬆️
suricata-verify 62.88% <ø> (+0.01%) ⬆️
unittests 59.18% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24094

@victorjulien victorjulien added this to the 8.0 milestone Jan 8, 2025
@catenacyber
Copy link
Contributor Author

By the way, this should have a good effect on https://redmine.openinfosecfoundation.org/issues/7462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants