fuzz/detect: forbid rule with any pcre on stream #12344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid fuzzing blocks on timeouts with known bad rules Completes commit 378f678 after oss-fuzz found another timeout Ticket: 4858
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12344 +/- ##
=======================================
Coverage 83.23% 83.23%
=======================================
Files 912 912
Lines 257647 257640 -7
=======================================
- Hits 214450 214445 -5
+ Misses 43197 43195 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Is the problem related to pcre's recursion features? Could a lower recursion limit help as well? |
Looks like it cf #12350 Which solution do you prefer ? |
|
Information: QA ran without warnings. Pipeline 24085 |
|
#12350 is the approved alternative |
|
Yeah wanted to try that first, as it will leave more functionality available for fuzz testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/4858
Describe changes:
Because such rules cause timeouts on oss-fuzz and block other findings
Completes commit 378f678