Skip to content

Commit

Permalink
Refactoring code so connections do not stay open longer than strictly…
Browse files Browse the repository at this point in the history
… necessary (to avoid timeout errors on DataBricks). Increasing required version of FeatureExtraction to avoid warning about use of deprecated argument `oracleTempSchema`. Fixing nesting cohorts to end at end of observation.
  • Loading branch information
Admin_mschuemi authored and Admin_mschuemi committed Dec 19, 2024
1 parent b0bdae7 commit 52d89fc
Show file tree
Hide file tree
Showing 6 changed files with 526 additions and 315 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: MethodEvaluation
Type: Package
Title: Package for Evaluation of Estimation Methods
Version: 2.3.1
Date: 2024-12-11
Date: 2024-12-16
Authors@R: c(
person("Martijn", "Schuemie", , "[email protected]", role = c("aut", "cre"))
)
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ Changes:

1. Updating Circe-generated SQL (to avoid errors on DataBricks).

2. Refactoring code so connections do not stay open longer than strictly necessary (to avoid timeout errors on DataBricks).

3. Increasing required version of FeatureExtraction to avoid warning about use of deprecated argument `oracleTempSchema`.

4. Fixing nesting cohorts to end at end of observation.


MethodEvaluation 2.3.0
======================
Expand Down
3 changes: 1 addition & 2 deletions R/Plots.R
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ plotCoverageInjectedSignals <- function(logRr, seLogRr, trueLogRr, region = 0.95

vizD$label <- paste(round(100 * vizD$fraction), "%", sep = "")
vizD$group <- factor(vizD$group, levels = c("Below CI", "Within CI", "Above CI"))
theme <- ggplot2::element_text(colour = "#000000", size = 10)
plot <- with(vizD, {
ggplot2::ggplot(vizD, ggplot2::aes(x = as.factor(trueRr), y = fraction)) +
ggplot2::geom_bar(ggplot2::aes(fill = group), stat = "identity", position = "stack", alpha = 0.8) +
Expand All @@ -181,7 +180,7 @@ plotCoverageInjectedSignals <- function(logRr, seLogRr, trueLogRr, region = 0.95
panel.grid.major = ggplot2::element_blank(),
axis.ticks = ggplot2::element_blank(),
axis.text.y = ggplot2::element_blank(),
axis.text.x = theme,
axis.text.x = ggplot2::element_text(colour = "#000000", size = 10),
legend.key = ggplot2::element_blank(),
legend.position = "right"
)
Expand Down
Loading

0 comments on commit 52d89fc

Please sign in to comment.