Removing reference to oracleTempSchema when calling FeatureExtraction

OHDSI · Dec 13, 2024 · b0bdae7 · b0bdae7
1 parent 2e3b6f1
commit b0bdae7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -22,7 +22,7 @@ BugReports: https://github.com/OHDSI/MethodEvaluation/issues
 Depends:
   R (>= 3.5.0),
   DatabaseConnector (>= 6.0.0),
-  FeatureExtraction (>= 3.0.0),
+  FeatureExtraction (>= 3.7.0),
   Cyclops (>= 3.0.0)
 Imports:
   dplyr,

diff --git a/R/CreateReferenceSetCohorts.R b/R/CreateReferenceSetCohorts.R
@@ -600,7 +600,7 @@ synthesizeReferenceSetPositiveControls <- function(connectionDetails,
       minOutcomeCountForInjection = 25,
       workFolder = injectionFolder,
       modelThreads = max(1, round(maxCores / 8)),
-      generationThreads = min(6, maxCores),
+      generationThreads = min(3, maxCores),
       covariateSettings = covariateSettings
     )
     saveRDS(result, injectionSummaryFile)

diff --git a/R/PositiveControlSynthesis.R b/R/PositiveControlSynthesis.R
@@ -509,7 +509,7 @@ synthesizePositiveControls <- function(connectionDetails,
       ParallelLogger::logInfo("Extracting covariates for fitting outcome model(s)")
       covariateData <- FeatureExtraction::getDbCovariateData(
         connection = conn,
-        oracleTempSchema = tempEmulationSchema,
+        tempEmulationSchema = tempEmulationSchema,
         cdmDatabaseSchema = cdmDatabaseSchema,
         cohortTable = "#sampled_person",
         cohortTableIsTemp = TRUE,
@@ -635,7 +635,7 @@ synthesizePositiveControls <- function(connectionDetails,
         DatabaseConnector::executeSql(conn, sql, progressBar = FALSE, reportOverallTime = FALSE)
         covariateData <- FeatureExtraction::getDbCovariateData(
           connection = conn,
-          oracleTempSchema = tempEmulationSchema,
+          tempEmulationSchema = tempEmulationSchema,
           cdmDatabaseSchema = cdmDatabaseSchema,
           cohortTable = "#selected_person",
           cohortTableIsTemp = TRUE,