-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] base_user_show_email: Migration to 18.0. #718
[18.0][MIG] base_user_show_email: Migration to 18.0. #718
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: server-auth-16.0/server-auth-16.0-base_user_show_email Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-base_user_show_email/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functional and code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional and Technical review
This PR has the |
@@ -20,7 +20,7 @@ | |||
</field> | |||
</record> | |||
<record id="user_email_tree" model="ir.ui.view"> | |||
<field name="name">res.users.show_email.tree</field> | |||
<field name="name">res.users.show_email.list</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but this is an unnecessary change that can break extensions inheriting it.
/ocabot migration base_user_show_email |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 8cba86b. Thanks a lot for contributing to OCA. ❤️ |
I migrated it through this PR