Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_user_show_email: Migration to 18.0. #718

Merged
merged 16 commits into from
Nov 16, 2024

Conversation

lef-adhoc
Copy link

@lef-adhoc lef-adhoc commented Oct 18, 2024

I migrated it through this PR

@lef-adhoc lef-adhoc changed the title 18.0 mig base user show email [18.0][MIG] base_user_show_email: Migration to 18.0. Oct 18, 2024
Copy link

@JrAdhoc JrAdhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functional and code review

Copy link

@matiasperalta1 matiasperalta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and Technical review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@@ -20,7 +20,7 @@
</field>
</record>
<record id="user_email_tree" model="ir.ui.view">
<field name="name">res.users.show_email.tree</field>
<field name="name">res.users.show_email.list</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but this is an unnecessary change that can break extensions inheriting it.

@dreispt
Copy link
Member

dreispt commented Nov 16, 2024

/ocabot migration base_user_show_email
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 16, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-718-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 16, 2024
13 tasks
@OCA-git-bot OCA-git-bot merged commit eb2b533 into OCA:18.0 Nov 16, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8cba86b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.