Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 18.0 #698

Open
5 of 12 tasks
OCA-git-bot opened this issue Oct 6, 2024 · 8 comments
Open
5 of 12 tasks

Migration to version 18.0 #698

OCA-git-bot opened this issue Oct 6, 2024 · 8 comments
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Milestone

Comments

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 6, 2024

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

@OCA-git-bot OCA-git-bot added help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress labels Oct 6, 2024
@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 6, 2024
@ap-wtioit
Copy link
Contributor

working on (ready for review) auth_oidc #705

@moncefarajdal
Copy link

Working on user_log_view and auth_admin_passkey

@moncefarajdal
Copy link

user_log_view : #711

@moncefarajdal
Copy link

auth_user_case_insensitive : #712

@moncefarajdal
Copy link

I have a question: Should I add my name in the contributors in the README file before the pull request is merged?

@pedrobaeza
Copy link
Member

If the migration means some significant time (not only changing the version number), then yes, it's acceptable that you become a contributor there.

@moncefarajdal
Copy link

@pedrobaeza In this module auth_user_case_insensitive there was a significant change in the super()._login method so I adapted it to the new version and also updated the test cases. Does this count as a significant contribution?

@pedrobaeza
Copy link
Member

Go ahead then. Take into account that this is a bit subjective, and what "we" (understood as the community) don't want is that people abuses the system to place it as a top contributor. But right now, your contributions seem valuable and checked carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Projects
None yet
Development

No branches or pull requests

4 participants