Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP][16.0] auth_saml: download the provider metadata #647

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Commits on May 14, 2024

  1. [IMP] auth_saml: download the provider metadata

    On Office365, what you get when configuring an application for SAML
    authentication is the URL of the federation metadata document. This URL
    is stable, but the content of the document is not. I suspect some of the
    encryption keys can be updated / renewed over time. The result is that
    the configured provider in Odoo suddenly stops working, because the
    messages sent by the Office365 provider can no longer be validated by
    Odoo (because the federation document is out of date). Downloading the
    new version and updating the auth.saml.provider record fixes the issue.
    
    This PR adds a new field to store the URL of the metadata document. When
    this field is set on a provider, you get a button next to it in the form
    view to download the document from the URL. The button will not update
    the document if it has not changed.
    
    Additionally, when a SignatureError happens, we check if downloading the
    document again fixes the issue.
    gurneyalex authored and Ricardoalso committed May 14, 2024
    Configuration menu
    Copy the full SHA
    625df40 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    899db88 View commit details
    Browse the repository at this point in the history