Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP][16.0] auth_saml: download the provider metadata #647

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[IMP][16.0] auth_saml: download the provider metadata #647

wants to merge 2 commits into from

Conversation

Ricardoalso
Copy link

@Ricardoalso Ricardoalso commented May 14, 2024 •
edited
Loading

Migration to 16 of #602 feature

@OCA-git-bot
Copy link
Contributor

Hi @vincent-hatakeyama,
some modules you are maintaining are being modified, check this out!

@Ricardoalso Ricardoalso marked this pull request as draft May 14, 2024 07:52
gurneyalex and others added 2 commits May 14, 2024 10:00
@gurneyalex @Ricardoalso
[IMP] auth_saml: download the provider metadata
625df40 
On Office365, what you get when configuring an application for SAML
authentication is the URL of the federation metadata document. This URL
is stable, but the content of the document is not. I suspect some of the
encryption keys can be updated / renewed over time. The result is that
the configured provider in Odoo suddenly stops working, because the
messages sent by the Office365 provider can no longer be validated by
Odoo (because the federation document is out of date). Downloading the
new version and updating the auth.saml.provider record fixes the issue.

This PR adds a new field to store the URL of the metadata document. When
this field is set on a provider, you get a button next to it in the form
view to download the document from the URL. The button will not update
the document if it has not changed.

Additionally, when a SignatureError happens, we check if downloading the
document again fixes the issue.
@Ricardoalso
Fix logic of SELECT FOR UDPDATE to only lock records that will be upd…
899db88 
…ated
@gurneyalex gurneyalex marked this pull request as ready for review May 14, 2024 14:24
@gurneyalex
Copy link
Member

/ocabot merge minor

@gurneyalex gurneyalex added this to the 16.0 milestone May 14, 2024
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-647-by-gurneyalex-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 14, 2024
@OCA-git-bot
Merge PR #647 into 16.0
7bed6c3 
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-647-by-gurneyalex-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ricardoalso @OCA-git-bot @gurneyalex