Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] base_user_show_email: Migration to 17.0 #605

Open
wants to merge 14 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] base_user_show_email: Migration to 17.0 #605

wants to merge 14 commits into from

Conversation

lav-adhoc
Copy link

No description provided.

p-tombez and others added 14 commits January 22, 2024 07:39
@p-tombez @lav-adhoc
[12.0][ADD] base_user_show_email
2e77863
@OCA-git-bot @lav-adhoc
[UPD] README.rst
2dcc307
@bruno-zanotti @lav-adhoc
[IMP] base_user_show_email: black, isort, prettier
4872ffa
@bruno-zanotti @lav-adhoc
[MIG] base_user_show_email: Migration to 13.0
3b1ae78
@oca-travis @lav-adhoc
[UPD] Update base_user_show_email.pot
18e91ca
@OCA-git-bot @lav-adhoc
[UPD] README.rst
07c4076
@vib-adhoc @lav-adhoc
[MIG] base_user_show_email: Migration to 16.0
e637757
@lav-adhoc
[UPD] Update base_user_show_email.pot
435a1d0
@OCA-git-bot @lav-adhoc
[UPD] README.rst
dbca9ef
@OCA-git-bot @lav-adhoc
[UPD] README.rst
72cb767
@mymage @lav-adhoc
Added translation using Weblate (Italian)
24e499a
@mymage @lav-adhoc
Translated using Weblate (Italian)
cd66892 
Currently translated at 100.0% (2 of 2 strings)

Translation: server-auth-16.0/server-auth-16.0-base_user_show_email
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-base_user_show_email/it/
@lav-adhoc
[IMP] base_user_show_email: pre-commit execution
014806d
@lav-adhoc
[17.0][MIG] base_user_show_email: Migration to 17.0
bb2b766
@lav-adhoc lav-adhoc changed the title 17.0 mig base user show email [17.0][MIG] base_user_show_email: Migration to 17.0 Jan 23, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
@github-actions github-actions bot closed this Jun 30, 2024
@lav-adhoc
Copy link
Author

@sbidoul
Hello, can you re-open this pr and review it? thanks

@lef-adhoc lef-adhoc mentioned this pull request Oct 18, 2024
Merged
@lav-adhoc
Copy link
Author

@pedrobaeza hi Pedro, can you re-open this pr and review it? thanks

@pedrobaeza
Copy link
Member

I'm not able to re-open it, sorry.

@sbidoul sbidoul reopened this Oct 23, 2024
@sbidoul sbidoul removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 23, 2024
@pedrobaeza
Copy link
Member

/ocabot migration base_user_show_email

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 23, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 23, 2024
Open
19 tasks
@lav-adhoc
Copy link
Author

@pedrobaeza @sbidoul thanks. what i have to do with the error in the coverage? Add some tests?

@pedrobaeza
Copy link
Member

Codecov is not mandatory. It's just a metric to show the code not covered by tests (and sometimes lies).

@lav-adhoc
Copy link
Author

@sbidoul hi, can you merge it? thanks

@lav-adhoc
Copy link
Author

@pedrobaeza hi, can you merge it? thanks

pedrobaeza
pedrobaeza requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It contains the infamous .deb package that must be removed, and the changes in README.rst are not in the proper commit. Please redo the migration again. At the end, it's only to switch 16 to 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@lef-adhoc lef-adhoc lef-adhoc approved these changes

@matiasperalta1 matiasperalta1 matiasperalta1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.