[18.0][MIG] base_report_to_printer: Migration to 18.0 #371

trisdoan · 2024-10-14T09:44:01Z

Note

Missing commits from 14.0 are ported in [17.0][FW] oca-port: forward missing commits from 14.0 #370
Tests are failed due to lack of CUPS server configured

Changes in 18.0

ir.property was removed in odoo/odoo@de302c2. Hence, replace default value for property_printing_action_id with invoked function.
doall & numbercall fields were removed from ir_cron in odoo/odoo@3a9949a
callable is not validated in selection any longer due to performance cost in odoo/odoo@eaef3d2. So, initialise AVAILABLE_ACTION_TYPES with the precomputed value instead of the function which returns the precomputed value.

This changes

Take this chance to replace percent format with f-string

sebalix · 2024-10-23T12:45:03Z

Have you a clue why CUPS is not running in the tests? (I compared the test.yml GH workflow file with the 17.0, and didn't saw real difference...)

nilshamerlinck · 2024-10-24T08:33:33Z

these tests don't need a real cups server to run, as calls are mocked
what is new is that 18.0 repos are now configured with OCA_ENABLE_CHECKLOG_ODOO=1, so the warnings are blocking
but these WARNING odoo odoo.addons.base_report_to_printer.models.printing_server: Failed to connect to the CUPS server on localhost:631. Check that the CUPS server is running and that you can reach it from the Odoo server. are actually expected, as concerned tests are testing some failure cases
so @trisdoan could you please use the .assertLogs context manager to trap these logs? see here for an example

ivantodorovich

non blocking comment
pre-approving: just the tests to fix

ivantodorovich · 2024-10-24T11:54:42Z

base_report_to_printer/models/printing_action.py

-            ("client", "Send to Client"),
-            ("user_default", "Use user's defaults"),
-        ]
+    _available_action_types = AVAILABLE_ACTION_TYPES


I think I liked the previous code better (here, and in all other similar cases), as it allowed for easier extension through overrides.
I wonder, what motivated this change?

Hi @ivantodorovich, thanks for your in-depth review

As Odoo native decided to bypass the validation when the selection is a callable in here, it breaks some logic of the module, e.g:

report-print-send/base_report_to_printer/tests/test_res_users.py

Lines 15 to 19 in 58cba79

def test_available_action_types_excludes_user_default(self):

"""It should not contain `user_default` in avail actions"""

self.user_vals["printing_action"] = "user_default"

with self.assertRaises(ValueError):

self.new_record()

But my approach supports extension as well, no?

Could it work with a property? So we keep a method to ease the override

Hi @sebalix, using 'property' is a good approach 👍 , thank you

I updated the code

trisdoan · 2024-10-28T08:59:22Z

~~DRAFT: update test~~

Migrate ir_report.py to new API Migrate printing.py to new API Migrate res_users.py to new API Migrate report_xml_action.py to new API Migrate wizard/update_printers.py to new API Better view for wizard Recursion when calling a method with old-style api signature from browse Remove the Lock because it is useless on multiprocess Replace it by a database lock so the different processes are all aware of the lock and the last update timestamp. browse is called often enough to call the update routine (even too much) Implements the print on the new 'report' model Restore the print capability on deprecated reports Update copyrights Improve form view, add search view for printers Update translations, add a string to URI so it is uppercased missing api decorator We need the report in print_document and print options (needed in printer_tray) Move the 'skip_update' right in the browse, it prevents a loop See odoo/odoo#3644 Also, it helps to have the value set/read in context close to each other. Avoid to hits the database too many times to check if the list of printers needs to be refreshed. Keep the last update datetime in cache and invalidate this datetime if is is older than POLL_INTERVAL. Thus, one process won't hit the DB more than 1 time every POLL_INTERVAL (10 seconds currently) to check if it needs to update the list. Refresh the list of printers every 15 seconds instead of 10 Extract a method so it will be easier to override in printer_tray Error on installation of the module Invalidate the cache when the table is created so the table_exists() method returns a fresh value after creation of the table Use a cron instead of threads to update printers status The implementation with threads was blocking the loading of the server in multiprocess. Using a cron will lower the frequency of the updates but at least it is simple and reliable. Fixes OCA#14 Do not write the printer status if it has not changed Avoid unnecessary UPDATE every minute Clean the XML file (remove eval, reindent) Give access to models to all users for reading So they are able to print

[Usability] Auto-add Administrator user to the Print group Make XML code more readable base_report_to_printer: add support for remote CUPS server (not just localhost) More logging and better error handling Add CUPS_HOST in more debug logs

Instead, a notification is displayed to the user. When report.get_pdf() is called on a report that must be printer, it will print the report *and* returns the pdf, thus code that calls directly report.get_pdf() will print the pdf on the printer as expected. Fixes OCA#16

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

By calling `super.get_pdf` in print_document we can encounter trouble with MRO resolution that prevent custom report parser (e.g. override of `get_pdf`) to be called. The fix consist of not calling `super` and prevent multiple call to 'printer.print_document'

* context was lost while getting report * now it will be passed using with_context * could be used for print_options (example: pass copies amount for productlabals)

cups is an external dependency, if it is not installed Odoo will not start. OCA guidelines specify guidelines for External dependencies, code is from there.

OCA-git-bot · 2024-10-28T12:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

chienandalu · 2024-11-18T09:02:07Z

I forwarded several commits up to 17.0, could you update your migration base?

If the CUPS server isn't available the user won't be able to do anything to print the report they need. At last we can give them the chance to have a fallback behavior downloading the document. TT47134

- Add access rules to the wizard - Set a fallback name for the printers and respect the user custom ones TT45159

… new thread

Better handling of exceptions feedback. A notification will show up with the issued printer and report and a button for the user to download the report as a fallback to the failure. TT51628

trisdoan · 2024-11-19T04:59:37Z

I forwarded several commits up to 17.0, could you update your migration base?

Hi @chienandalu, it's done

base_report_to_printer/static/src/js/qweb_action_manager.esm.js

trisdoan mentioned this pull request Oct 14, 2024

Migration to version 18.0 #366

Open

1 task

This was referenced Oct 15, 2024

[18.0][MIG] base_report_to_label_printer: Migration to 18.0 Kimkhoi3010/report-print-send#1

Open

[18.0][MIG] base_report_to_label_printer: Migration to 18.0 #372

Open

ivantodorovich approved these changes Oct 24, 2024

View reviewed changes

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from a5aae19 to 3b27729 Compare October 28, 2024 08:58

trisdoan marked this pull request as draft October 28, 2024 08:59

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch 5 times, most recently from ad38882 to aec32f6 Compare October 28, 2024 09:31

guewen and others added 16 commits October 28, 2024 16:34

Add OCA as author of OCA addons

3d50a33

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

The alteration of the context has no effect

4aa6b4b

Improve bloated condition test

7b5bf5e

[FIX] base_report_to_printer: make get_pdf callable from 8.0 api

d5fac51

[FIX] test if the module is installed before monkey patching

7aa2392

[PEP8]

6e68bba

[UPD] prefix versions with 8.0

7a5094c

pass context to printer to use it for example in print_options()

521a3eb

* context was lost while getting report * now it will be passed using with_context * could be used for print_options (example: pass copies amount for productlabals)

Add support for multiple copies

14dceb9

[IMP] Soft fail on missing cups import

39783ee

cups is an external dependency, if it is not installed Odoo will not start. OCA guidelines specify guidelines for External dependencies, code is from there.

[MIG] base_report_to_printer: Upgrade to v9

49fdb7f

Fix placeholder for repo in readme.rst

21b1933

alexis-via and others added 3 commits November 19, 2024 09:20

base_report_to_printer: fix string

64f778e

[IMP] base_report_to_printer: out of connection fallback to client

43eab67

If the CUPS server isn't available the user won't be able to do anything to print the report they need. At last we can give them the chance to have a fallback behavior downloading the document. TT47134

[FIX] base_report_to_printer: update printers wizard

92723f3

- Add access rules to the wizard - Set a fallback name for the printers and respect the user custom ones TT45159

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from 58cba79 to 5ab9f3e Compare November 19, 2024 02:54

sergio-teruel and others added 3 commits November 19, 2024 09:57

[IMP] base_report_to_printer: Add printer option to launch reports in…

b719f7e

… new thread

[IMP] base_report_to_printer: exceptions notifications

995e8fa

Better handling of exceptions feedback. A notification will show up with the issued printer and report and a button for the user to download the report as a fallback to the failure. TT51628

[IMP] base_report_to_printer: pre-commit auto fixes

05716e3

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from 5ab9f3e to 02e1d3b Compare November 19, 2024 02:57

trisdoan marked this pull request as draft November 19, 2024 02:58

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from 02e1d3b to 4fd9a30 Compare November 19, 2024 03:41

trisdoan marked this pull request as ready for review November 19, 2024 03:41

trisdoan marked this pull request as draft November 19, 2024 03:52

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch 8 times, most recently from 4bfd4d8 to 128c02e Compare November 19, 2024 04:57

trisdoan marked this pull request as ready for review November 19, 2024 04:59

chienandalu suggested changes Nov 19, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Nov 19, 2024

[MIG] base_report_to_printer: Migration to 18.0

d0276e8

trisdoan force-pushed the 18.0-mig-base_report_to_printer branch from 128c02e to d0276e8 Compare December 5, 2024 10:55

trisdoan requested a review from chienandalu December 5, 2024 10:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] base_report_to_printer: Migration to 18.0 #371

[18.0][MIG] base_report_to_printer: Migration to 18.0 #371

trisdoan commented Oct 14, 2024 •

edited

Loading

sebalix commented Oct 23, 2024

nilshamerlinck commented Oct 24, 2024

ivantodorovich left a comment

ivantodorovich Oct 24, 2024

trisdoan Oct 28, 2024

sebalix Oct 28, 2024

trisdoan Nov 19, 2024 •

edited

Loading

trisdoan commented Oct 28, 2024 •

edited

Loading

OCA-git-bot commented Oct 28, 2024

chienandalu commented Nov 18, 2024

trisdoan commented Nov 19, 2024

	def test_available_action_types_excludes_user_default(self):
	"""It should not contain `user_default` in avail actions"""
	self.user_vals["printing_action"] = "user_default"
	with self.assertRaises(ValueError):
	self.new_record()

[18.0][MIG] base_report_to_printer: Migration to 18.0 #371

Are you sure you want to change the base?

[18.0][MIG] base_report_to_printer: Migration to 18.0 #371

Conversation

trisdoan commented Oct 14, 2024 • edited Loading

Note

Changes in 18.0

This changes

sebalix commented Oct 23, 2024

nilshamerlinck commented Oct 24, 2024

ivantodorovich left a comment

Choose a reason for hiding this comment

ivantodorovich Oct 24, 2024

Choose a reason for hiding this comment

trisdoan Oct 28, 2024

Choose a reason for hiding this comment

sebalix Oct 28, 2024

Choose a reason for hiding this comment

trisdoan Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

trisdoan commented Oct 28, 2024 • edited Loading

OCA-git-bot commented Oct 28, 2024

chienandalu commented Nov 18, 2024

trisdoan commented Nov 19, 2024

trisdoan commented Oct 14, 2024 •

edited

Loading

trisdoan Nov 19, 2024 •

edited

Loading

trisdoan commented Oct 28, 2024 •

edited

Loading