Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_report_to_label_printer: Migration to 18.0 #372

Open
wants to merge 14 commits into
base: 18.0
Choose a base branch
from

Conversation

Kimkhoi3010
Copy link

@Kimkhoi3010 Kimkhoi3010 commented Oct 16, 2024

@Kimkhoi3010 Kimkhoi3010 mentioned this pull request Oct 16, 2024
1 task
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch 3 times, most recently from 670a304 to c9d8629 Compare October 22, 2024 10:45
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thanks!

@sebalix
Copy link
Contributor

sebalix commented Jan 21, 2025

Hello @Kimkhoi3010, can you rebase and drop your dependency commit please? 🙏

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch from c9d8629 to c8bad7a Compare January 21, 2025 11:10
@Kimkhoi3010 Kimkhoi3010 marked this pull request as draft January 21, 2025 11:18
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch 6 times, most recently from 174b0fe to e23a7d6 Compare January 21, 2025 16:30
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch from e23a7d6 to 8c9e9c1 Compare January 22, 2025 03:46
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch 2 times, most recently from f14470f to dea58ce Compare January 22, 2025 04:05
@Kimkhoi3010 Kimkhoi3010 marked this pull request as ready for review January 22, 2025 04:08
@Kimkhoi3010 Kimkhoi3010 requested a review from sebalix January 22, 2025 04:08
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, small comment

@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-base_report_to_label_printer branch from dea58ce to fcc463f Compare January 23, 2025 02:31
@Kimkhoi3010 Kimkhoi3010 requested a review from sebalix January 23, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants