Skip to content

Commit

Permalink
Re-enable patch for improving armor stand culling
Browse files Browse the repository at this point in the history
  • Loading branch information
Aeltumn committed Jul 29, 2023
1 parent 772d23e commit 6096d83
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ individual rule and how it interprets the incoming packet.
- New feature: Performance improvements to rendering colored custom models (+~5 fps)
- New feature: Performance improvements to rendering all custom models (+~15 fps)
- Player heads now support showing any skin texture instead of requiring a player uuid. This fixes issues with showing the skins of disguised players.
- Removed model culling improvements as they are obsolete in 1.20

TODOs:
- Add a system to determine when a server is running an outdated protocol version
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.noxcrew.noxesium.mixin.client.entity;
package com.noxcrew.noxesium.mixin.entity;

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.LevelRenderer;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.noxcrew.noxesium.mixin.client.entity;
package com.noxcrew.noxesium.mixin.entity;

import com.mojang.blaze3d.vertex.DefaultVertexFormat;
import com.mojang.blaze3d.vertex.PoseStack;
Expand Down Expand Up @@ -34,6 +34,11 @@

/**
* Update the culling bounding box for armor stands to include the hitbox of the model on their head or arms.
*
* This patch will be dropped in the future as usage of display entities is preferred over armor stands. Display
* entities allow you to modify these culling hitboxes on the server-side which allows for finer control and wider
* adoption. This patch only works for servers that specifically use head items on armor stands which makes it
* ill-suited for wide adoption.
*/
@Mixin(LivingEntity.class)
public abstract class LivingEntityMixin {
Expand Down
6 changes: 5 additions & 1 deletion fabric/src/main/resources/noxesium.mixins.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"component.MinecraftExt",
"component.SkinManagerExt",
"component.SkullBlockEntityExt",
"entity.LevelRendererMixin",
"info.MinecraftMixin",
"info.OptionInstanceExt",
"info.OptionInstanceMixin",
Expand All @@ -39,5 +40,8 @@
],
"injectors": {
"defaultRequire": 1
}
},
"mixins": [
"entity.LivingEntityMixin"
]
}

0 comments on commit 6096d83

Please sign in to comment.