Add redisClustervCommandToNode and redisClustervAppendCommandToNode to library API #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unikmhz
changed the title
bjosv
approved these changes
Aug 5, 2024
|
Looks good, thanks! |
bjosv
added a commit
to bjosv/libvalkey
that referenced
this pull request
Aug 18, 2024
- valkeyClustervCommandToNode() - valkeyClustervAppendCommandToNode() From Nordix/hiredis-cluster#231 Co-authored-by: Alex Unigovsky <[email protected]>
bjosv
added a commit
to bjosv/libvalkey
that referenced
this pull request
Aug 19, 2024
- valkeyClustervCommandToNode() - valkeyClustervAppendCommandToNode() From Nordix/hiredis-cluster#231 Co-authored-by: Alex Unigovsky <[email protected]> Signed-off-by: Björn Svensson <[email protected]>
bjosv
added a commit
to valkey-io/libvalkey
that referenced
this pull request
Aug 19, 2024
- valkeyClustervCommandToNode() - valkeyClustervAppendCommandToNode() From Nordix/hiredis-cluster#231 Co-authored-by: Alex Unigovsky <[email protected]> Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230.
I did not add new tests as original redisClusterv* APIs are not tested directly, and test coverage should not change. Please comment in this PR if separate specialized tests are required.
The only disadvantage of this PR that I see, is that va_start() is called in more cases. It can add some (albeit minuscule) overhead, but all such cases end in an error anyway.