Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new APIs for variadic cluster commands #70

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Aug 19, 2024

  • valkeyClustervCommandToNode()
  • valkeyClustervAppendCommandToNode()

From Nordix/hiredis-cluster#231

- valkeyClustervCommandToNode()
- valkeyClustervAppendCommandToNode()

From Nordix/hiredis-cluster#231
Co-authored-by: Alex Unigovsky <[email protected]>

Signed-off-by: Björn Svensson <[email protected]>
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are just missing variants.

The spellcheck error is not introduced here. Should be fixed in another PR. (Just add "valkey" to the wordlist?)

@bjosv
Copy link
Collaborator Author

bjosv commented Aug 19, 2024

Yes, its seems to complain about following text in standalone.md.
See [include/valkey.h](include/valkey.h) for more details
Weird though..possible a simple fix, or alternatively we replace spellcheck with typos as in the valkey repo

@bjosv
Copy link
Collaborator Author

bjosv commented Aug 19, 2024

Adding the word seem to be enough this time

@bjosv bjosv merged commit 0cbffcf into valkey-io:main Aug 19, 2024
40 of 41 checks passed
@bjosv bjosv deleted the add-api branch August 19, 2024 08:33
@zuiderkwast
Copy link
Collaborator

It may be the case that the spellchecker ignores text within backticks. I have a vague memory of this. If so, we could silence this kind of errors by placing backticks around the file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants