Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure --model has to be set when not training from scratch #286

Closed
wants to merge 3 commits into from

Conversation

gdewael
Copy link

@gdewael gdewael commented Jan 30, 2024

I'm adding this pull request directly to the main branch as it does not add extra features.
This PR adds an extra compatibility check between two casanovo options.

Currently, casanovo train with a config.yaml specifying train_from_scratch: False, can still be run without setting the --model parameter. (It then still trains from scratch). I've added a raise ValueError that makes setting --model required when not training from scratch.

@bittremieux
Copy link
Collaborator

Thanks for the contribution. Incidentally, train_from_scratch has actually recently been removed, as it was indeed a superfluous config option. See #275. This will be provided in the next Casanovo release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants