Ensure --model has to be set when not training from scratch #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding this pull request directly to the main branch as it does not add extra features.
This PR adds an extra compatibility check between two casanovo options.
Currently,
casanovo train
with aconfig.yaml
specifyingtrain_from_scratch: False
, can still be run without setting the--model
parameter. (It then still trains from scratch). I've added araise ValueError
that makes setting--model
required when not training from scratch.