Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-tauri: 1.7.1-unstable-2024-08-16 -> 2.0.1 #346277

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Oct 3, 2024

Changelog: https://github.com/tauri-apps/tauri/releases/tag/tauri-v2.0.1
Diff: tauri-apps/tauri@2b61447...tauri-v2.0.1

This release contains breaking changes. See the migration guide

cargo-tauri_1 has also been introduced in order to keep other packages that still haven't updated to v2 building. It should be removed in 25.05 as it will no longer be maintained upstream

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Eveeifyeve
Copy link
Contributor

Also add a eval warning to Nix/NixOs.

@getchoo
Copy link
Member Author

getchoo commented Oct 4, 2024

Nothing is removed, so I don't believe there is much of a need; I also wouldn't want to cause evaluation warnings for all packages in the tree that still use v1. The release notes should do well enough for now as breaking updates are expected in new releases, and then a throw can be used for cargo-tauri_1 in 25.05 once it's no longer needed here

@Eveeifyeve
Copy link
Contributor

Eveeifyeve commented Oct 4, 2024

It seems like @ofborg is failing since it missing maintainers at hook.
/ofborg/checkout/1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-0/pkgs/by-name/ca/cargo-tauri/hook.nix:51:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants