Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default.nix #346258

Closed
wants to merge 1 commit into from
Closed

Update default.nix #346258

wants to merge 1 commit into from

Conversation

guttermonk
Copy link

@guttermonk guttermonk commented Oct 3, 2024

libinput-gestures: 2.76 -> 2.77

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Trying to upgrade nixpkgs to version 2.77 of libinput-gestures.
@guttermonk guttermonk mentioned this pull request Oct 3, 2024
13 tasks
@rhendric
Copy link
Member

rhendric commented Oct 3, 2024

Please follow the commit conventions.

@guttermonk
Copy link
Author

Please follow the commit conventions.

Ok, updated.

@rhendric
Copy link
Member

rhendric commented Oct 3, 2024

No, you've edited the GitHub PR description but not the underlying Git commit. I think you need to use the Git CLI for this; type git commit --amend and then push with --force-with-lease.

@guttermonk
Copy link
Author

No, you've edited the GitHub PR description but not the underlying Git commit. I think you need to use the Git CLI for this; type git commit --amend and then push with --force-with-lease.

I was unable to make the updates with the commands you suggested, so I made a new pull request: #346289

@guttermonk
Copy link
Author

Recreated here: #346289

@guttermonk guttermonk closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants