Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default.nix #345624

Closed
wants to merge 1 commit into from
Closed

Update default.nix #345624

wants to merge 1 commit into from

Conversation

guttermonk
Copy link

Updated version to 2.77 of libinput-gestures.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Updated version and hash
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/trying-to-get-a-nix-package-updated-am-i-doing-this-right/53822/1

@rhendric
Copy link
Member

rhendric commented Oct 3, 2024

Have a look at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-create-pull-requests; you should be targeting the master branch, not nixos-24.05. (After a PR is merged to master, you can try backporting it to release-24.05.)

(Go ahead and make another PR; I'm closing this one only because changing the base of PRs in the GitHub interface often leads to hundreds of people being notified.)

@rhendric rhendric closed this Oct 3, 2024
@guttermonk
Copy link
Author

guttermonk commented Oct 3, 2024

Have a look at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-create-pull-requests; you should be targeting the master branch, not nixos-24.05. (After a PR is merged to master, you can try backporting it to release-24.05.)

(Go ahead and make another PR; I'm closing this one only because changing the base of PRs in the GitHub interface often leads to hundreds of people being notified.)

Okay, I made the same changes on master. Those instructions are sort of long and confusing, so still not sure if I did it right, but please let me know if there's anything I need to change.

Here's the new pull request: #346258

@guttermonk guttermonk deleted the patch-2 branch October 4, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants