Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark python3Packages.krb5 broken and fix requests-kerberos on Darwin #337576

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Mark python3Packages.krb5 broken and fix requests-kerberos on Darwin #337576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84fb2aa
python3Packages.krb5: mark broken on Darwin
Aug 26, 2024
951f578
python3Packages.requests-kerberos: avoid broken krb5 package on Darwin
Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/development/python-modules/krb5/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
lib,
stdenv,
buildPythonPackage,
cython,
fetchPypi,
Expand Down Expand Up @@ -42,5 +43,6 @@ buildPythonPackage rec {
homepage = "https://github.com/jborean93/pykrb5";
license = licenses.mit;
maintainers = teams.deshaw.members;
broken = stdenv.isDarwin; # TODO: figure out how to build on Darwin
};
}
14 changes: 9 additions & 5 deletions pkgs/development/python-modules/requests-kerberos/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
lib,
stdenv,
buildPythonPackage,
cryptography,
fetchFromGitHub,
Expand All @@ -24,11 +25,14 @@ buildPythonPackage rec {
hash = "sha256-s1Q3zqKPSuTkiFExr+axai9Eta1xjw/cip8xzfDGR88=";
};

propagatedBuildInputs = [
cryptography
requests
pyspnego
] ++ pyspnego.optional-dependencies.kerberos;
propagatedBuildInputs =
[
cryptography
requests
pyspnego
]
# Avoid broken Python krb5 package on Darwin
++ lib.optionals (!stdenv.isDarwin) pyspnego.optional-dependencies.kerberos;

nativeCheckInputs = [
pytestCheckHook
Expand Down