Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark python3Packages.krb5 broken and fix requests-kerberos on Darwin #337576

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

de11n
Copy link

@de11n de11n commented Aug 26, 2024

Description of changes

Python krb5 package doesn't build on Darwin. I spent some time trying to fix it, but it will require more time than I can offer right now. It's causing requests-kerberos to fail on Darwin which is widely used. This should be a suitable stop-gap until we can figure out how to make Python krb5 work on Darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Elliot Cameron added 2 commits August 26, 2024 18:20
It should be possible to make this work on Darwin, but it will require some work.
@Kumm-Kai
Copy link

Kumm-Kai commented Aug 27, 2024

Building requests-kerberos now works on aarch64-darwin.
The package where I've noticed the broken build openstack-client now also successfully builds again.
However, I don't authenticate to OpenStack using Kerberos, so I can't confirm if that still works.

Thanks for the quick fix ❤️

@de11n de11n requested a review from natsukium August 27, 2024 14:45
@SuperSandro2000 SuperSandro2000 merged commit 7d31b51 into NixOS:master Aug 28, 2024
31 checks passed
@de11n de11n deleted the upstream-requests-kerberos-fix branch August 28, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants