Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nvidia container toolkit docker contamination #336626

Open
wants to merge 3 commits into
base: release-24.05
Choose a base branch
from
Open

Fix nvidia container toolkit docker contamination #336626

wants to merge 3 commits into from

Commits on Aug 22, 2024

  1. nvidia-container-toolkit: do not shadow docker executable 

    At this time, the nvidia-container-toolkit derivation installs a
docker executable that shadows the main one, and that is not thought
to forward commands to the original docker command, causing issues to
users when the `nvidia-container-toolkit` is in scope and they try to
call to `docker`.

(cherry picked from commit df2df4c)
    @ereslibre
    ereslibre committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1cd89ed View commit details
    Browse the repository at this point in the history

  2. virtualisation/docker: fix nvidia wrapper 

    Although CDI should be used in order to not require container runtime
wrappers anymore, fix the nvidia-container-runtime integration with
Docker for cases when Docker < 25.

(cherry picked from commit f7b4d57)
    @ereslibre
    ereslibre committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    50e7e13 View commit details
    Browse the repository at this point in the history

  3. nvidia-podman: remove nvidia wrapper 

    Since version 4.1.0, podman has support for CDI, and is the
recommended way to expose GPU's for containers for podman.

More information: https://web.archive.org/web/20240729183805/https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html#configuring-podman

(cherry picked from commit 058e8f5)
    @ereslibre
    ereslibre committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9cff87c View commit details
    Browse the repository at this point in the history