Fix nvidia container toolkit docker contamination #336626
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this time, the nvidia-container-toolkit derivation installs a docker executable that shadows the main one, and that is not thought to forward commands to the original docker command, causing issues to users when the `nvidia-container-toolkit` is in scope and they try to call to `docker`. (cherry picked from commit df2df4c)
Although CDI should be used in order to not require container runtime wrappers anymore, fix the nvidia-container-runtime integration with Docker for cases when Docker < 25. (cherry picked from commit f7b4d57)
Since version 4.1.0, podman has support for CDI, and is the recommended way to expose GPU's for containers for podman. More information: https://web.archive.org/web/20240729183805/https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html#configuring-podman (cherry picked from commit 058e8f5)
ereslibre
force-pushed
the
backport-pr-331071
branch
from
1e40556
to
9cff87c
Compare
|
This is, technically, a breaking change which we normally do not backport. The original state of things is sufficiently sad though maybe we make an exception (would need a note in release notes)... idk hard to know what people depend on and what they don't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Backport #331071
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.