gnomeExtensions.systemd-manager: package manually #321469
Conversation
github-actions
bot
added
the
6.topic: GNOME
There was a problem hiding this comment.
Please mention that as per https://extensions.gnome.org/extension/4174/systemd-manager/ is no longer uploaded to e.g.o in the commit message.
There was a problem hiding this comment.
I wonder if it is to bypass the review. I have skimmed the source and did not notice anything immediately suspicious.
There was a problem hiding this comment.
I wonder if it is to bypass the review. I have skimmed the source and did not notice anything immediately suspicious.
You mean to say that perhaps the author of the extension is not uploading version to e.g.o to bypass the review of the gnome extensions website?
| installPhase = '' | ||
| mkdir -p $out/share/gnome-shell/extensions/ | ||
| mv [email protected] $out/share/gnome-shell/extensions/ | ||
| ''; |
There was a problem hiding this comment.
There are also some Polkit files but we probably do not want to install them to default location since they loosen security. Maybe copy them to share/doc/systemd-manager directory for easier enabling and mention them in longDescription. Though the policy also FHS path so that would need to be patched.
There was a problem hiding this comment.
I add the rule to security.polkit.extraConfig directly. Would it be better to source that file from this package directly?
There was a problem hiding this comment.
I add the rule to
security.polkit.extraConfigdirectly. Would it be better to source that file from this package directly?
I read this in the polkit service:
# The polkit daemon reads action/rule files
environment.pathsToLink = [ "/share/polkit-1" ];I think it means that if the package would provide files in that directory - it should work if it the polkit service is enabled and the package is environment.systemPackage.
There was a problem hiding this comment.
Pushed a suggestion regarding the polkit policy.
As per https://extensions.gnome.org/extension/4174/systemd-manager/ this is no longer uploaded to e.g.o
|
Is this ready? |
As I said here, I pushed 2 commits that fix the polkit files dilemma. If you think these changes are good @linsui then yes I think we can merge this. |
|
Your changes are good to me. :) |
|
How can I override this package? I thought this makes manually packaged extensions not overridable. Changing this to (extensions: extensions // (import ./manuallyPackaged.nix { inherit callPackage; }))works. |
|
I think @linsui's suggestion makes sense. |
Description of changes
Closes #279638
hardpixel/systemd-manager#19
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.