Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.guillotine: package manually #322835

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

huskyistaken
Copy link
Contributor

Description of changes

Starting from version 19 guillotine is no longer updated on https://extensions.gnome.org.
Notably Gnome 46 compatibility is introduced in version 22.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 27, 2024
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, looks good overall.

pkgs/desktops/gnome/extensions/guillotine/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/gnome/extensions/guillotine/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/gnome/extensions/guillotine/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/gnome/extensions/guillotine/default.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor

Changes look good, could you please rebase and squash your commits such that there will be 2 of them?

maintainers: add huskyistaken
gnomeExtensions.guillotine: package manually

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit picks.. Otherwise should be good to go.

pkgs/desktops/gnome/extensions/guillotine/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/gnome/extensions/guillotine/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/gnome/extensions/guillotine/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/gnome/extensions/guillotine/default.nix Outdated Show resolved Hide resolved
@doronbehar doronbehar merged commit 8fabf58 into NixOS:master Jul 31, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants