nixos/fzf: bring back keybindings and completion option removed in #298692

[SuperSandro2000]

Description of changes

According to upstream feedback in junegunn/fzf#3722, half of the changes done in #298692 are being revert.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[marsam]

I think we could also revert 1035a9efdfe4 and optionally de5b2ef

[SuperSandro2000]

Added that. I didn't do a revert commit for the first one as that would have multiple merge conflicts.

[marsam]

LGTM. Thank you!

[SuperSandro2000]

Removed a line I left in from the first draft.

Also I could finally test this e2e as yesterday nixos-rebuild wanted to build electron for me.

[SebTM]

Result of nixpkgs-review pr 303213 run on x86_64-linux 1

2 packages blacklisted:

• nixos-install-tools
• tests.nixos-functions.nixos-test

51 packages built:

• adl
• ani-cli
• arsenal
• arsenal.dist
• catcli
• catcli.dist
• clerk
• dra-cla
• felix-fm
• fishPlugins.fzf-fish
• fontpreview
• fzf
• fzf-git-sh
• fzf-zsh
• fzf.man
• gh-f
• gh-notify
• kakounePlugins.fzf-kak
• kns
• license-cli
• lunarvim
• mov-cli
• mov-cli.dist
• navi
• python311Packages.pyfzf
• python311Packages.pyfzf.dist
• python312Packages.pyfzf
• python312Packages.pyfzf.dist
• ripgrep-all
• spacevim
• sway-launcher-desktop
• sysz
• tmuxPlugins.extrakto
• tmuxPlugins.fuzzback
• tmuxPlugins.session-wizard
• tmuxPlugins.t-smart-tmux-session-manager
• tmuxPlugins.tmux-fzf
• unipicker
• vimPlugins.fzf-hoogle-vim
• vimPlugins.fzf-lua
• vimPlugins.fzf-vim
• vimPlugins.fzfWrapper
• vimPlugins.telescope-zoxide
• vimPlugins.vim-fzf-coauthorship
• vimPlugins.vim-zettel
• vimPlugins.zoxide-vim
• xmloscopy
• yazi
• ytfzf
• zoxide
• zsh-forgit

[SebTM]

Build and tested it locally - LGTM so going ahead and merge it 🙏🏻