fzf: expose individual shell plugins in $out/share #303145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the fzf readme: > Note > > --bash, --zsh, and --fish options are only available in fzf 0.48.0 or > later. If you have an older version of fzf, or want finer control, you can > source individual script files in the /shell directory. The location of the > files may vary depending on the package manager you use. Please refer to the > package documentation for more information. (e.g. apt show fzf)
Br1ght0ne
approved these changes
Apr 10, 2024
13 tasks
|
Sorry, I misread the release notes. I thought the scripts were being deprecated. I think we could revert e3812e187592#diff-0ec453fc4296765a0ab62b0363770e9d24ee57f5e83cb89581ebd097ceeec131L78-L86 |
I don't understand that code but I believe you 👍 Feel free to go ahead and revert and close this PR. |
|
Closing in favor of #303213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
From the fzf readme:
This is for the "or want finer control" people, who can load individual files directly from "${pkgs.fzf}/share/shell/...".
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.