Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python{27,310}Packages.deprecation: remove unittest2, break on Python 2 #202236

Merged
merged 2 commits into from
Dec 2, 2022
Merged

python{27,310}Packages.deprecation: remove unittest2, break on Python 2 #202236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3dec2e
python{27,310}Packages.deprecation: constrain unittest2 to python2
tjni Nov 21, 2022
119ea0e
python27Packages.deprecation: remove unittest2, break on Python 2
tjni Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions pkgs/development/python-modules/deprecation/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
{ lib, buildPythonPackage, fetchPypi
{ lib
, buildPythonPackage
, fetchPypi
, fetchpatch
, packaging
, python
, pythonAtLeast
, pythonOlder
, unittest2
, unittestCheckHook
}:

tjni marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -17,7 +15,7 @@ buildPythonPackage rec {
sha256 = "1zqqjlgmhgkpzg9ss5ki8wamxl83xn51fs6gn2a8cxsx9vkbvcvj";
};

patches = lib.optionals (pythonAtLeast "3.10") [
patches = [
# fixes for python 3.10 test suite
(fetchpatch {
url = "https://github.com/briancurtin/deprecation/pull/57/commits/e13e23068cb8d653a02a434a159e8b0b7226ffd6.patch";
Expand All @@ -28,11 +26,7 @@ buildPythonPackage rec {

propagatedBuildInputs = [ packaging ];

# avoiding mass rebuilds for python3.9, but no longer
# needed with patch
checkInputs = [ unittestCheckHook ] ++ lib.optionals (pythonOlder "3.10") [
unittest2
];
checkInputs = [ unittestCheckHook ];

meta = with lib; {
description = "A library to handle automated deprecations";
Expand Down