python{27,310}Packages.deprecation: remove unittest2, break on Python 2 #202236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The
deprecation
package makes use of features fromunittest
only available since Python 3.4, but it also supports Python 2.7. It usesunittest2
, which backports those features. Discussion about this is in briancurtin/deprecation#54.We'd like to stop packaging
unittest2
it since it is unmaintained and caused us some pain on Python 3.10, so we apply briancurtin/deprecation#57.In the first commit, this PR applies the patch unconditionally (eating the rebuilds, since it's unclear if it will be accepted and released upstream) and also hides the
unittest2
requirement inside of apython2-modules
override.In the second commit, this PR removes the python2-modules override, explicitly choosing to drop support for it in Python 2.
Related to #154264 and #154650.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes