Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: .to_public() now doesn't underline for pyright #49

Merged
merged 10 commits into from
Nov 11, 2024
Merged

fix: .to_public() now doesn't underline for pyright #49

merged 10 commits into from
Nov 11, 2024

Conversation

cyberglot
Copy link
Contributor

.to_public() now doesn't underline for pyright plus some other typing improvements. It makes .to_public() an idempotent function if the value is already public.

@cyberglot
fix: .to_public() now doesn't underline for pyright
f4c429f 
plus some other typing improvements
@cyberglot cyberglot marked this pull request as ready for review November 8, 2024 16:15
@cyberglot cyberglot requested a review from a team as a code owner November 8, 2024 16:15
navasvarela
navasvarela approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@navasvarela navasvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please make sure to increase the release version and add typing_extensions to [tool.uv].

@navasvarela navasvarela mentioned this pull request Nov 11, 2024
Closed
3 tasks
@navasvarela navasvarela merged commit a815088 into main Nov 11, 2024
4 checks passed
@navasvarela navasvarela deleted the cyberglot/if_else_fix branch November 11, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablojhl pablojhl pablojhl approved these changes

@Jmgr Jmgr Jmgr approved these changes

@navasvarela navasvarela navasvarela approved these changes

@lumasepa lumasepa Awaiting requested review from lumasepa lumasepa is a code owner automatically assigned from NillionNetwork/lcx

@manel1874 manel1874 Awaiting requested review from manel1874 manel1874 is a code owner automatically assigned from NillionNetwork/lcx

@jcabrero jcabrero Awaiting requested review from jcabrero jcabrero is a code owner automatically assigned from NillionNetwork/lcx

@nilmemo nilmemo Awaiting requested review from nilmemo nilmemo is a code owner automatically assigned from NillionNetwork/lcx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyberglot @navasvarela @Jmgr @pablojhl