Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if_else then to_public correctly typed #50

Closed
wants to merge 1 commit into from
Closed

fix: if_else then to_public correctly typed #50

wants to merge 1 commit into from

Conversation

navasvarela
Copy link

Fixes https://github.com/NillionNetwork/nada-lang/issues/52

Changes

Fixes some type checking issues, and concretely the type checking issue when issuing a to_public after if_else.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Backwards compatibility analysis completed (if applicable). "Will this change require recompilation and upload of user programs?"

@navasvarela navasvarela requested a review from a team as a code owner November 8, 2024 16:09
@navasvarela navasvarela force-pushed the fix/if-else-to-public branch from 53d6995 to cd5f296 Compare November 8, 2024 16:12
@navasvarela
Copy link
Author

Fixed in #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jmgr Jmgr Awaiting requested review from Jmgr Jmgr is a code owner automatically assigned from NillionNetwork/lcx

@lumasepa lumasepa Awaiting requested review from lumasepa lumasepa is a code owner automatically assigned from NillionNetwork/lcx

@manel1874 manel1874 Awaiting requested review from manel1874 manel1874 is a code owner automatically assigned from NillionNetwork/lcx

@jcabrero jcabrero Awaiting requested review from jcabrero jcabrero is a code owner automatically assigned from NillionNetwork/lcx

@pablojhl pablojhl Awaiting requested review from pablojhl pablojhl is a code owner automatically assigned from NillionNetwork/lcx

@nilmemo nilmemo Awaiting requested review from nilmemo nilmemo is a code owner automatically assigned from NillionNetwork/lcx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@navasvarela