Enhancement: Implement bubble sort #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
Aug 29, 2024
| # We should provide bubble sort as well! | ||
| raise NotImplementedError | ||
| """Bubble sort algorithm. | ||
|
|
There was a problem hiding this comment.
A bigger project might want more documentation, but this is great!
|
@andrea-petrocchi, sorry that I will close this now without merging. Unfortunately, I looked at the other PR first, which collided. (And of course you even commented on the issue!) |
|
@seberg thank you for your comments. I also saw the other PR being completed before mine. In cases like this is it good practice to close the PR myself or to let the reviewer do that? |
|
I think it is great if you just take initiative in such cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9.