Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implement bubble sort #9

Closed
seberg opened this issue Aug 20, 2024 · 2 comments
Closed

ENH: Implement bubble sort #9

seberg opened this issue Aug 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@seberg
Copy link
Collaborator

seberg commented Aug 20, 2024

We currently have a small implementation of a merge sort algorithm only. We would like to also provide a bubble_sort implementation.

For information on bubble sort, please see: https://en.wikipedia.org/wiki/Bubble_sort

Working on this issue

Implementing bubblesort consists of the following things:

  • Find the existing bubble_sort stub and replace it with your implementation.
  • Add documentation (you can look at merge_sort for inspiration).
  • Add some tests by expanding test_bubble_sort in test_sorting.py.

Once you have made your changes, and committed them to a new branch, you can create a PR!

@seberg seberg added the enhancement New feature or request label Aug 20, 2024
@andrea-petrocchi
Copy link
Contributor

I'm on it.

@Nikoleta-v3
Copy link
Owner

I am closing this. It was addressed by #30 and #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants