Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast start time from G7 #3262

Closed

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Dec 30, 2023

PLEASE DON'T REVIEW
Please review 3263 instead

Fixes: #3250

This PR changes what is broadcasted, for sensor start time, only if a known G7 firmware is being used to the time coming from G7, which is the only time that matters as far as when the device will stop working.

I have not tested this because I cannot compile AAPS since we use a different version of gradle.

I will update if I can test.

@Navid200 Navid200 marked this pull request as draft January 1, 2024 15:21
@Navid200
Copy link
Collaborator Author

Navid200 commented Jan 1, 2024

I think this is a better approach: #3263

@Navid200 Navid200 closed this Jan 8, 2024
@Navid200 Navid200 deleted the Navid_2023_12_28 branch May 30, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid G7 start time sent to AAPS
1 participant