-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid G7 start time sent to AAPS #3250
Comments
So I believe that the cause of this would be if xDrip doesn't register the sensor stopping for your previous sensor session. Do you think that could have happened? I think that when xDrip gets the last reading from your old sensor it will mark the sensor session as stopped and that will reset that timer. We might be able to put some failsafes in for this but I'm wondering if you can share whether you think that could be what happened here? |
@jamorham I waited for my previous device to stop working. But, I never tapped on stop sensor and I don't want to do that even if it is still running. |
@jamorham that is likely I often don't wait till the very end of the sensor
to switch to the new one. I presoak the new one for a few hours and then
switch when it's most convenient for me.
…On Sat, Dec 23, 2023, 6:27 AM Navid ***@***.***> wrote:
@jamorham <https://github.com/jamorham>
I am looking at my classic status page and see the start time is shown to
have been on November 27, almost a month ago.
But, I switched to a new device 5 days ago.
I waited for my previous device to stop working. But, I never tapped on
stop sensor and I don't want to do that even if it is still running.
At that point, I changed the transmitter ID.
—
Reply to this email directly, view it on GitHub
<#3250 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHEDIVYDZ2CNYGYNDRA7OHTYK3L4NAVCNFSM6AAAAABA6VVH4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGI4TIOBVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
My sensor just reached 10.5 days and stopped working. I then changed the transmitter ID to that of the new device that had been running for 12 hours. |
xDrip shows 3 start times for G6. 1- Transmitter activation time on G5/G6/G7 status page as "Transmitter Days" reported by the transmitter 2 and 3 are not necessarily the same for G6 for example if you start the sensor with your receiver or a t:slim pump. When you use a G7, there is only one start time and that is the moment you use the applicator to insert the device. We don't reinvent the wheel every time a new device is added to xDrip. We use the existing code as much as possible and we gradually tweak it to cleanup any discrepancies for the new device. Let's see what's the best way to update the classic status page with respect to the sensor start time. In my opinion, there is no value in maintaining the time xDrip first becomes aware of a new G7 device. There is no way we can use a G7 in non-native mode. So, I suggest we remove sensor start from the classic status page. This brings me to my question, how this relate to AAPS. @jgslade |
@jgslade https://github.com/NightscoutFoundation/xDrip/releases/tag/2023.11.29 |
I've installed that release, so changes yet, bit I'll be replacing my
sensor tomorrow. So I'll post back what info is sent to AAPS with the new
sensor.
I'll be changing the sensor about 5 hours before it naturally ends.
…On Thu, Dec 28, 2023, 2:32 PM Navid ***@***.***> wrote:
@jgslade <https://github.com/jgslade>
Would you please use the xDrip release of November 29 and see if the same
thing happens or not?
Thanks
https://github.com/NightscoutFoundation/xDrip/releases/tag/2023.11.29
—
Reply to this email directly, view it on GitHub
<#3250 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHEDIVZST3DTUOUDK2S2Q2TYLXQPPAVCNFSM6AAAAABA6VVH4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRGUYDENJYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No, please don't worry about that. You can install whatever release you like. |
I have been told that actually version December 5 is required for this relatively new feature to work for G6. |
Look forward to testing
…On Thu, Dec 28, 2023, 9:53 PM Navid ***@***.***> wrote:
I have been told that actually version December 5 is required for this
relatively new feature to work for G6.
So, I think I may be able to open a PR to fix this based on that for G7.
—
Reply to this email directly, view it on GitHub
<#3250 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHEDIV4NRGPSUA4EDUI53CLYLZEEPAVCNFSM6AAAAABA6VVH4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRG4ZDONBRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR should fix the broadcast. So, AAPS should show the correct sensor remaining time. |
When I get a chance to get to my computer I'll try and build with that PR to see if it works. |
I've not built xDrip before and my first attempt didn't go well. I might be able to work on this a bit more tomorrow.
|
Android Studio is on hedgehog on my system, and I'm not finding a download for giraffe. |
I have another PR, which I believe is a better solution: For Android Studio, see: https://developer.android.com/studio/archive |
Installing Giraffe now |
Which build option should I use? For AAPS I use the generate signed Bundle/APK, do I do the same thing with xDrip? |
That's what I do. But, please note that you will not be able to install it over the official release. You will either need to use a test phone, or uninstall before installing. If you uninstall, you will lose all your xDrip history and settings. So, please plan this carefully. |
Can I save the settings to a settings file then load from the settings file? It looks like it successfully built. |
If you are currently using the official xDrip, you can create a backup on Google Drive. it backs up both database and settings. https://navid200.github.io/xDrip/docs/GoogleDriveBackup.html After you are done with the test, you can install the official release again and restore the backup. If you want your settings for the test, save the settings in a file and you will be able to restore after installing your version. |
If you used 3263, the start time shown on the classic status page would be correct also. Thanks for testing |
@Der-Schubi Yes, I know. |
Yes, that's apparently the one I did not merge. Will try in six days. |
You can try it now. That PR stops caring about when you start the xDrip session. It looks at the transmitter and updates the classic status page and what is sends to AAPS from it. So, it will correct it even if you update to it now. |
Works, thanks! |
How about AAPS? |
Had it already right there, but the Treatments menu shows a User entry with CGM Sensor Insert. |
Please post in the PR to mention that you have tested it with your results. Thanks |
As of the xDrip release of April 19, 2024, the correct G7 start time is broadcasted to AAPS. If you still experience this problem, please report it here. |
Discussed in #3249
Originally posted by jgslade December 21, 2023
The Classic Status Page is showing the start date of my previous sensor but the G5/G6/G7 status page and the home screen are showing the correct sensor age.
The text was updated successfully, but these errors were encountered: