-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UnitSeries #822
base: dev
Are you sure you want to change the base?
add UnitSeries #822
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #822 +/- ##
==========================================
+ Coverage 73.77% 73.85% +0.08%
==========================================
Files 60 60
Lines 7184 7191 +7
Branches 1514 1514
==========================================
+ Hits 5300 5311 +11
+ Misses 1457 1453 -4
Partials 427 427
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #822 +/- ##
==========================================
+ Coverage 73.77% 73.85% +0.08%
==========================================
Files 60 60
Lines 7184 7191 +7
Branches 1514 1514
==========================================
+ Hits 5300 5311 +11
+ Misses 1457 1453 -4
Partials 427 427
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #822 +/- ##
==========================================
+ Coverage 73.72% 73.75% +0.02%
==========================================
Files 60 60
Lines 7190 7198 +8
Branches 1517 1518 +1
==========================================
+ Hits 5301 5309 +8
Misses 1459 1459
Partials 430 430
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a roundtrip test to tests/integration/ui_write/test_misc.py?
Yeah, I'll do that |
Oliver wants to talk about this PR on Thursday before we merge |
@bendichter @oruebel Where are we on this? |
is it really still WiP @bendichter or might want to be closed (or converted to draft at least)? |
Motivation
Part of plan to make spike waveforms accessible from Units table. See NeurodataWithoutBorders/nwb-schema#248
How to test the behavior?
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number ?