Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UnitSeries #822

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

add UnitSeries #822

wants to merge 5 commits into from

Conversation

bendichter
Copy link
Contributor

Motivation

Part of plan to make spike waveforms accessible from Units table. See NeurodataWithoutBorders/nwb-schema#248

How to test the behavior?

from pynwb.misc import Units, UnitSeries

units = Units()
us = UnitSeries('test_unit_series', np.array([0, 0, 1, 1], dtype=int), timestamps=[.1, .2, .3, .4], units=units, description='description')

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ?

@bendichter bendichter requested a review from ajtritt February 18, 2019 22:17
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #822 into dev will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #822      +/-   ##
==========================================
+ Coverage   73.77%   73.85%   +0.08%     
==========================================
  Files          60       60              
  Lines        7184     7191       +7     
  Branches     1514     1514              
==========================================
+ Hits         5300     5311      +11     
+ Misses       1457     1453       -4     
  Partials      427      427
Impacted Files Coverage Δ
src/pynwb/misc.py 87.15% <100%> (+0.88%) ⬆️
src/pynwb/form/build/map.py 72.38% <0%> (+0.19%) ⬆️
src/pynwb/form/spec/spec.py 78.93% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c22cd...2cfaae4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #822 into dev will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #822      +/-   ##
==========================================
+ Coverage   73.77%   73.85%   +0.08%     
==========================================
  Files          60       60              
  Lines        7184     7191       +7     
  Branches     1514     1514              
==========================================
+ Hits         5300     5311      +11     
+ Misses       1457     1453       -4     
  Partials      427      427
Impacted Files Coverage Δ
src/pynwb/misc.py 87.15% <100%> (+0.88%) ⬆️
src/pynwb/form/build/map.py 72.38% <0%> (+0.19%) ⬆️
src/pynwb/form/spec/spec.py 78.93% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c22cd...2cfaae4. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #822 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #822      +/-   ##
==========================================
+ Coverage   73.72%   73.75%   +0.02%     
==========================================
  Files          60       60              
  Lines        7190     7198       +8     
  Branches     1517     1518       +1     
==========================================
+ Hits         5301     5309       +8     
  Misses       1459     1459              
  Partials      430      430
Impacted Files Coverage Δ
src/pynwb/misc.py 87.27% <100%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5939d5...530034e. Read the comment docs.

Copy link
Member

@ajtritt ajtritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a roundtrip test to tests/integration/ui_write/test_misc.py?

@bendichter
Copy link
Contributor Author

Yeah, I'll do that

@bendichter
Copy link
Contributor Author

Oliver wants to talk about this PR on Thursday before we merge

@ajtritt
Copy link
Member

ajtritt commented Jul 30, 2019

@bendichter @oruebel Where are we on this?

@ajtritt ajtritt mentioned this pull request Jul 30, 2019
5 tasks
@yarikoptic
Copy link
Contributor

is it really still WiP @bendichter or might want to be closed (or converted to draft at least)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants