Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/add links to elec grp #828

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Enh/add links to elec grp #828

wants to merge 3 commits into from

Conversation

bendichter
Copy link
Contributor

Motivation

Adds links to ElectrodeGroup that facilitates queries between ElectrodeGroups and recorded data
depends on #827

How to test the behavior?

ElectrodeGroup('elec1', 'a test ElectrodeGroup', 'a nonexistent place', Device(),
               event_waveform=EventWaveform(), lfp=LFP())

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ?

ajtritt and others added 2 commits February 19, 2019 13:21
add acquisition (ElectricalSeries), event_waveform (EventWaveform),
and lfp (LFP) to ElectrodeGroup to facilitate queries
@bendichter bendichter requested a review from ajtritt February 19, 2019 22:41
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #828 into dev will increase coverage by <.01%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #828      +/-   ##
==========================================
+ Coverage   73.77%   73.78%   +<.01%     
==========================================
  Files          60       60              
  Lines        7184     7193       +9     
  Branches     1514     1517       +3     
==========================================
+ Hits         5300     5307       +7     
- Misses       1457     1458       +1     
- Partials      427      428       +1
Impacted Files Coverage Δ
src/pynwb/ecephys.py 97.41% <100%> (+0.06%) ⬆️
src/pynwb/form/build/map.py 72.29% <60%> (+0.1%) ⬆️
src/pynwb/form/spec/spec.py 78.41% <60%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c22cd...6acb6a8. Read the comment docs.

src/pynwb/data/nwb.ecephys.yaml Outdated Show resolved Hide resolved
@bendichter
Copy link
Contributor Author

Oliver wants to talk about this PR on Thursday before we merge

@ajtritt
Copy link
Member

ajtritt commented Jul 30, 2019

@bendichter @oruebel this has gone the way of #822 and #825. We should decide what to do on these

@bendichter bendichter marked this pull request as draft June 24, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants