Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid having to set rate=None explitctly when passing timestamps in mock_ElectricalSeries #1894

Merged
merged 6 commits into from
May 14, 2024
Merged

Avoid having to set rate=None explitctly when passing timestamps in mock_ElectricalSeries #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b81ca0c
set rate as optional value
h-mayorquin Apr 25, 2024
f962f46
changelog
h-mayorquin Apr 25, 2024
6945848
Update CHANGELOG.md
h-mayorquin May 13, 2024
2df0f03
Merge branch 'dev' into make_rate_optional_in_mock
h-mayorquin May 13, 2024
c2086a2
update CHANGELOG.md
stephprince May 14, 2024
a5bfe19
Update src/pynwb/testing/mock/ecephys.py
stephprince May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# PyNWB Changelog

## PyNWB 2.8.0 (Upcoming)

### Enhancements and minor changes
- Set rate default value inside `mock_ElectricalSeries` to avoid having to set `rate=None` explicitly when passing timestamps. @h-mayorquin [#1894](https://github.com/NeurodataWithoutBorders/pynwb/pull/1894)

## PyNWB 2.7.0 (May 2, 2024)

### Enhancements and minor changes
Expand Down
6 changes: 5 additions & 1 deletion src/pynwb/testing/mock/ecephys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def mock_ElectricalSeries(
name: Optional[str] = None,
description: str = "description",
data=None,
rate: float = 30000.0,
rate: Optional[float] = None,
timestamps=None,
starting_time: Optional[float] = None,
electrodes: Optional[DynamicTableRegion] = None,
Expand All @@ -80,6 +80,10 @@ def mock_ElectricalSeries(
conversion: float = 1.0,
offset: float = 0.,
) -> ElectricalSeries:

# Set a default rate if timestamps are not provided
rate = 30_000.0 if (timestamps is None and rate is None) else rate

electrical_series = ElectricalSeries(
name=name or name_generator("ElectricalSeries"),
description=description,
Expand Down
Loading