Avoid having to set rate=None explitctly when passing timestamps in mock_ElectricalSeries

[h-mayorquin]

Motivation

Right now you get the following error when trying to pass timestamps to the mock_ElectricalSeries function.

from pynwb.testing.mock.ecephys import mock_ElectricalSeries


mock_ElectricalSeries(timestamps=np.arange(10))
ValueError: Specifying rate and timestamps is not supported.

This is because we have rate=30,000.0 as a default value in the function signature. To make this work, the user has to explictly set rate=None, that is:

from pynwb.testing.mock.ecephys import mock_ElectricalSeries


mock_ElectricalSeries(timestamps=np.arange(10), rate=None)

This is too cumbersome. This PR simplifies this so this is not necessary. To do this, it moves the logic of default values inside the function.

I also added some missing typing.

How to test the behavior?

The code above should work.

Checklist

• Did you update CHANGELOG.md with your changes?
• Have you checked our Contributing document?
• Have you ensured the PR clearly describes the problem and the solution?
• Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
• Have you checked to ensure that there aren't other open Pull Requests for the same change?
• Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

[stephprince]

Sorry for the delayed review! Added a few small suggestions but otherwise looks good to me.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.93%. Comparing base (86b274d) to head (2df0f03).

❗ Current head 2df0f03 differs from pull request most recent head a5bfe19. Consider uploading reports for the commit a5bfe19 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1894      +/-   ##
==========================================
- Coverage   92.02%   83.93%   -8.10%     
==========================================
  Files          27       27              
  Lines        2620     2620              
  Branches      685      685              
==========================================
- Hits         2411     2199     -212     
- Misses        139      328     +189     
- Partials       70       93      +23     

Flag	Coverage Δ
integration	?
unit	83.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stephprince]

The failing checks are due to a separate hdmf-zarr issue hdmf-dev/hdmf-zarr#192 and are unrelated to these changes to mock_ElectricalSeries. So we will ignore them for now and go ahead and merge this PR.