Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ruff, update workflow versions #1853

Merged
merged 90 commits into from
Mar 23, 2024
Merged

Update to ruff, update workflow versions #1853

merged 90 commits into from
Mar 23, 2024

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Feb 22, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Fix #1854

  • Finish updating tox.ini to support 3.12
  • Update coverage and codespell
  • Migrate to use hatch and hatch-vcs
  • Fix ros3 failure
  • Update gallery tests to drop imp module for importlib.utils due to python 3.12
  • Add ruff and drop flake8

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@mavaylon1 mavaylon1 marked this pull request as ready for review March 14, 2024 17:29
@mavaylon1 mavaylon1 requested a review from rly March 14, 2024 17:29
rly
rly previously approved these changes Mar 23, 2024
@rly
Copy link
Contributor

rly commented Mar 23, 2024

Looks great. Thank you for taking care of this much needed infrastructure update @mavaylon1

@rly rly mentioned this pull request Mar 23, 2024
6 tasks
@mavaylon1 mavaylon1 merged commit 8d9aaa3 into dev Mar 23, 2024
23 of 24 checks passed
@mavaylon1 mavaylon1 deleted the workflow-updates branch March 23, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Migrate from setup.py to pyproject.toml
2 participants