Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install_developers.rst #1851

Closed
wants to merge 1 commit into from
Closed

Update install_developers.rst #1851

wants to merge 1 commit into from

Conversation

mavaylon1
Copy link
Collaborator

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
This is a small update to include install the doc requirements and to move all installs into one step. Looking forward, with a change from flake8 to ruff in an upcoming PR and a change to use pytest, this tutorial will change in the near future.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1 mavaylon1 self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65b2a7d) 91.95% compared to head (8eec9f2) 91.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1851   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          27       27           
  Lines        2661     2661           
  Branches      699      699           
=======================================
  Hits         2447     2447           
  Misses        142      142           
  Partials       72       72           
Flag Coverage Δ
integration 70.80% <ø> (ø)
unit 84.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly
Copy link
Contributor

rly commented Mar 23, 2024

I think #1853 supersedes this. Please confirm and close @mavaylon1

@mavaylon1 mavaylon1 closed this Mar 23, 2024
@mavaylon1 mavaylon1 deleted the tutorial_install branch March 23, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants