-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip mac sidecars #470
Merged
CodyCBakerPhD
merged 11 commits into
NeurodataWithoutBorders:dev
from
catalystneuro:sidecar
May 30, 2024
Merged
skip mac sidecars #470
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
83cdf4d
skip mac sidecars
pauladkisson 233a3f6
Merge branch 'dev' into sidecar
pauladkisson 46f52f2
moved skip to right after glob
pauladkisson d89e22c
added test for ._ nwb file
pauladkisson 01bf3d2
updated changelog
pauladkisson 32c0238
trigger pre-commit
pauladkisson 3ece625
trigger pre-commit
pauladkisson 1f88732
trigger pre-commit
pauladkisson 1211c68
reformat line break
CodyCBakerPhD 9d5306b
added non-matching timestamps to sidecar file
pauladkisson 91c1fcd
changed ._ file to last one in the list
pauladkisson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minimal NWB file would have no problems with it though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe bump the number of files to 4, do one of the common violations to the last one, and add
._
to the autogeneratednwbfile_path
of the last one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closer - it will have to be an additional one tacked onto the end though, not index 2 (since that already exists and has specific tests for it)
Either that or a simpler standalone unit test for just this particular behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok now the sidecar test file is the last one in the list and the no-error file is back to being the third