skip mac sidecars #470
skip mac sidecars #470
Conversation
|
Also CHANGELOG and simple test? (take one of the existing simple tests for an invalid file, make a copy of that file with the prefix, call that function on that directory and ensure it only reports issues with the non-sidecar) |
|
And also looks like you'll need to run pre-commit locally, since contributing from an organizations fork (the one exception where the pre-commit bit doesn't run) |
tests/test_inspector.py
Outdated
| @@ -103,6 +103,8 @@ def setUpClass(cls): | |||
| # Last file to be left without violations | |||
|
|
|||
| cls.nwbfile_paths = [str(cls.tempdir / f"testing{j}.nwb") for j in range(num_nwbfiles)] | |||
| nwbfiles.append(make_minimal_nwbfile()) | |||
There was a problem hiding this comment.
A minimal NWB file would have no problems with it though
There was a problem hiding this comment.
Maybe bump the number of files to 4, do one of the common violations to the last one, and add ._ to the autogenerated nwbfile_path of the last one?
There was a problem hiding this comment.
how about this?
There was a problem hiding this comment.
Closer - it will have to be an additional one tacked onto the end though, not index 2 (since that already exists and has specific tests for it)
Either that or a simpler standalone unit test for just this particular behavior
There was a problem hiding this comment.
ok now the sidecar test file is the last one in the list and the no-error file is back to being the third
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #470 +/- ##
==========================================
+ Coverage 87.04% 87.05% +0.01%
==========================================
Files 23 23
Lines 1250 1251 +1
==========================================
+ Hits 1088 1089 +1
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodyCBakerPhD
merged commit 9f242ff
into
NeurodataWithoutBorders:dev
|
Thanks @pauladkisson ! |
fixes #469