Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing asterisk for dandiset license #904

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix missing asterisk for dandiset license #904

merged 1 commit into from
Jul 30, 2024

Conversation

rly
Copy link
Collaborator

@rly rly commented Jul 30, 2024

Fix #903

@rly
Copy link
Collaborator Author

rly commented Jul 30, 2024

The current schema set up allows for a multi-select but then says "maxItems: 1" which counteracts that. If we are only going to allow one license, then we do not need to set up the schema as a multi-select.

@CodyCBakerPhD
Copy link
Collaborator

LGTM - thanks

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jul 30, 2024
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge July 30, 2024 16:12
@CodyCBakerPhD CodyCBakerPhD merged commit c39b9b3 into main Jul 30, 2024
12 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_license_required branch July 30, 2024 16:19
@rly rly mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodyCBakerPhD CodyCBakerPhD CodyCBakerPhD approved these changes

Assignees

@CodyCBakerPhD CodyCBakerPhD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License option on "Create Dandiset" form missing asterisk to indicate it is required
2 participants
@rly @CodyCBakerPhD