Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license metadata populated incorrectly #943

Closed
bendichter opened this issue Nov 10, 2024 · 6 comments · Fixed by #944
Closed

license metadata populated incorrectly #943

bendichter opened this issue Nov 10, 2024 · 6 comments · Fixed by #944

Comments

@bendichter
Copy link
Collaborator

Describe the issue

When you create a new dandiset, the license metadata is created incorrectly

image

It should be sent as a list with one element, but it is sent as a string, so the API instead breaks up the string and has a license for each letter.

Steps to Reproduce

Just go through the GUIDE tutorial and create a new dandiset on staging

Operating System

OSX

GUIDE Version

1.0.4

Code of Conduct

Yes

Did you confirm this issue was not already reported?

Yes

@bendichter
Copy link
Collaborator Author

@rly do you think you could look into this?

@rly
Copy link
Collaborator

rly commented Nov 11, 2024

Does it make sense to have a dandiset with both CC-BY-4.0 and CC0-1.0? DANDI allows both
image
see https://gui-staging.dandiarchive.org/dandiset/213889/draft

We could allow both, but if that's a bug or it is not a recommended practice to have both, we could require the user to select only one.

@oruebel
Copy link
Collaborator

oruebel commented Nov 11, 2024

Does it make sense to have a dandiset with both CC-BY-4.0 and CC0-1.0? DANDI allows both

Looking at the DANDI page, it seems like it may be intentionally allowing multiple licenses. I'd ping DANDI for clarification.

@rly
Copy link
Collaborator

rly commented Nov 12, 2024

Satra wrote: "this was set to allow modeling for a use case of dandisets with mixed assets, but in general only one should be chosen for a dandiset."

For NWB GUIDE purposes, I think limiting the license selection to one makes sense. (Otherwise, I would make the license selector a multi-select.)

@rly
Copy link
Collaborator

rly commented Nov 12, 2024

See #904 for the change that broke this.

@bendichter
Copy link
Collaborator Author

It's fine to only allow one, but I think it needs to be passed as a list of length 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants