-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend Refactor I] Reorganize core folders #792
Conversation
Mostly seems fine, PyInstaller build has one issue with the paths config: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/9196745515/job/25295551261?pr=792#step:13:55 |
for more information, see https://pre-commit.ci
Current PyInstaller problems from pypa/setuptools#4374 it seems |
@CodyCBakerPhD This is working as expected now, right? |
Doing more thorough testing later to be sure |
Gotcha. Thank you! |
Also I just noticed something in the CI - what are the 'Example Pipeline Tests' testing if they don't have any example data? Just the tutorials? |
Hmm.. I guess it just skips everything? https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/9198157905/job/25300243822?pr=792#step:10:175 |
Oh no! Yep you got it. I forgot to add the GIN download steps to the workflow after testing locally... |
We can deal with that in a follow-up then Current problem holding up PR is for building whereas the pipeline tests use dev mode, right? |
Correct. Trying to figure out where the |
for more information, see https://pre-commit.ci
OK, I still get the same warning when building on windows
(which is true, there is no 'electron' folder in 'renderer' in 'build') and the But the |
Ah figured it out. Just a simple bad path in the |
This PR reorganizes the core folder structure of the GUIDE to more clearly separate
src
files