Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend Refactor I] Reorganize core folders #792

Merged
merged 15 commits into from
May 24, 2024
Merged

Conversation

garrettmflynn
Copy link
Member

This PR reorganizes the core folder structure of the GUIDE to more clearly separate src files

@garrettmflynn garrettmflynn self-assigned this May 22, 2024
@CodyCBakerPhD
Copy link
Collaborator

Mostly seems fine, PyInstaller build has one issue with the paths config: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/9196745515/job/25295551261?pr=792#step:13:55

@CodyCBakerPhD
Copy link
Collaborator

Current PyInstaller problems from pypa/setuptools#4374 it seems

@garrettmflynn
Copy link
Member Author

@CodyCBakerPhD This is working as expected now, right?

@CodyCBakerPhD
Copy link
Collaborator

Doing more thorough testing later to be sure

@garrettmflynn
Copy link
Member Author

Gotcha. Thank you!

@CodyCBakerPhD
Copy link
Collaborator

Also I just noticed something in the CI - what are the 'Example Pipeline Tests' testing if they don't have any example data? Just the tutorials?

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn
Copy link
Member Author

Oh no! Yep you got it. I forgot to add the GIN download steps to the workflow after testing locally...

@CodyCBakerPhD
Copy link
Collaborator

Oh no! Yep you got it. I forgot to add the GIN download steps to the workflow after testing locally...

We can deal with that in a follow-up then

Current problem holding up PR is for building whereas the pipeline tests use dev mode, right?

@garrettmflynn
Copy link
Member Author

Correct. Trying to figure out where the renderer folder went now.

@CodyCBakerPhD
Copy link
Collaborator

OK, I still get the same warning when building on windows

cannot find specified resource "electron/renderer/assets/app-icon/logo-guide-draft.ico", nor relative to "D:\GitHub\nwb-guide\build", neither relative to project dir ("D:\GitHub\nwb-guide")

(which is true, there is no 'electron' folder in 'renderer' in 'build') and the .exe in the build folder fails

But the dist works just fine so getting this through

@CodyCBakerPhD CodyCBakerPhD merged commit 79714c9 into main May 24, 2024
22 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the separate-stories branch May 24, 2024 15:17
@garrettmflynn
Copy link
Member Author

Ah figured it out. Just a simple bad path in the package.json file. Will submit a follow-up

@CodyCBakerPhD CodyCBakerPhD changed the title Reorganize core folders [Frontend Refactor I] Reorganize core folders May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants