-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend Refactor II] Separate stories from src #801
Conversation
Well, besides a massive rebase lol Despite it being branched from #792 looks like a lot of conflicts |
Other than the rebase, this should be good to go. Was going to hold off on other changes until later—though we may just want to reproduce this and get it in quickly. Could flatten our desired changes into this then too |
Would you want to handle that then? (might be best to just re-implement on a fresh branch if the Git CLI is too messy to handle this) |
for more information, see https://pre-commit.ci
…ataWithoutBorders/nwb-guide into separate-stories-from-src
for more information, see https://pre-commit.ci
Wasn't too bad to merge. I think we can get this through as-is. Just FYI, this was a result of merging #800. Was easy to tell since the merge conflicts span the entire file—indicating that each line had some sort of change associated with it. |
Oh, durr.. the other most common source of massive merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet looks good to me
Oof, looks like Chromatic needs some reroutes: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/9277056004/job/25525472646?pr=801 |
Thanks for pinging me! Looks mostly handled, forgot to review. |
Awesome - last PR along these lines was about renaming the subfolders for electron, correct? |
Yep! Will tackle that tomorrow :) |
@garrettmflynn This was the next follow-up right? Anything left to do here?