Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom schema validation #639

Merged
merged 9 commits into from
Mar 9, 2024
6 changes: 3 additions & 3 deletions environments/environment-Linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ dependencies:
- numcodecs = 0.11.0
# install these from conda-forge so that dependent packages get included in the distributable
- jsonschema = 4.18.0 # installs jsonschema-specifications
- pydantic[email] = 1.10.12 # installs email-validator
- pip
- pip:
- pyinstaller-hooks-contrib == 2024.2 # Fix needed for pydantic v2; otherwise imports pydantic.compiled
- chardet == 5.1.0
- configparser == 6.0.0
- flask == 2.3.2
- flask-cors == 4.0.0
- flask_restx == 1.1.0
- neuroconv @ git+https://github.com/catalystneuro/neuroconv.git@main#neuroconv[full]
- dandi >= 0.58.1
- neuroconv @ git+https://github.com/catalystneuro/neuroconv.git@try_remove_packaing_bound#neuroconv[full]
- dandi >= 0.60.0
- pytest == 7.4.0
- pytest-cov == 4.1.0
- scikit-learn == 1.4.0
3 changes: 1 addition & 2 deletions environments/environment-MAC-arm64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ dependencies:
- pytables = 3.8 # pypi build fails on arm64 so install from conda-forge (used by neuroconv deps)
# install these from conda-forge so that dependent packages get included in the distributable
- jsonschema = 4.18.0 # installs jsonschema-specifications
- pydantic[email] = 1.10.12 # installs email-validator
- pip
- pip:
- chardet == 5.1.0
Expand All @@ -22,7 +21,7 @@ dependencies:
- flask-cors == 4.0.0
- flask_restx == 1.1.0
- neuroconv @ git+https://github.com/catalystneuro/neuroconv.git@main#neuroconv[full]
- dandi >= 0.58.1
- dandi >= 0.60.0
- pytest == 7.4.0
- pytest-cov == 4.1.0
- scikit-learn == 1.4.0
3 changes: 1 addition & 2 deletions environments/environment-MAC.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ dependencies:
- numcodecs = 0.11.0
# install these from conda-forge so that dependent packages get included in the distributable
- jsonschema = 4.18.0 # installs jsonschema-specifications
- pydantic[email] = 1.10.12 # installs email-validator
- pip
- pip:
- chardet == 5.1.0
Expand All @@ -18,7 +17,7 @@ dependencies:
- flask-cors == 4.0.0
- flask_restx == 1.1.0
- neuroconv @ git+https://github.com/catalystneuro/neuroconv.git@main#neuroconv[full]
- dandi >= 0.58.1
- dandi >= 0.60.0
- pytest == 7.4.0
- pytest-cov == 4.1.0
- scikit-learn == 1.4.0
6 changes: 3 additions & 3 deletions environments/environment-Windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ dependencies:
- pywin32 = 303
- git = 2.20.1
- setuptools = 58.0.4
- pydantic[email] = 1.10.12 # installs email-validator
- pip
- pip:
- pyinstaller-hooks-contrib == 2024.2 # Fix needed for pydantic v2; otherwise imports pydantic.compiled
- chardet == 5.1.0
- configparser == 6.0.0
- flask == 2.3.2
- flask-cors === 3.0.10
- flask_restx == 1.1.0
- neuroconv @ git+https://github.com/catalystneuro/neuroconv.git@main#neuroconv[full]
- dandi >= 0.58.1
- neuroconv @ git+https://github.com/catalystneuro/neuroconv.git@try_remove_packaing_bound#neuroconv[full]
- dandi >= 0.60.0
- pytest == 7.2.2
- pytest-cov == 4.1.0
- scikit-learn == 1.4.0
4 changes: 2 additions & 2 deletions src/renderer/src/stories/JSONSchemaForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -428,10 +428,10 @@ export class JSONSchemaForm extends LitElement {

const isRow = typeof rowName === "number";

const resolvedValue = e.path.reduce((acc, token) => acc[token], resolved);
const resolvedValue = e.instance; // Get offending value
const schema = e.schema; // Get offending schema

// ------------ Exclude Certain Errors ------------

// Allow for constructing types from object types
if (e.message.includes("is not of a type(s)") && "properties" in schema && schema.type === "string")
return;
Expand Down
3 changes: 2 additions & 1 deletion src/renderer/src/stories/Search.js
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,8 @@ export class Search extends LitElement {
}}

@blur=${(blurEvent) => {
if (blurEvent.relatedTarget.classList.contains("option")) return;
const relatedTarget = blurEvent.relatedTarget;
if (relatedTarget && relatedTarget.classList.contains("option")) return;
this.submit();
}}

Expand Down
Loading