-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom schema validation #639
Conversation
for more information, see https://pre-commit.ci
@garrettmflynn This prevents the flag from raising on entry to the field, but I can't move past the file metadata page due to the same previous schema error |
…rodataWithoutBorders/nwb-guide into fix-custom-schema-validation
Can you try again? This is working fine on my end. Avoided a stray error in the Search component with the last push. May have something to do with what you observed |
I'm surprised; after digging into this it was coming from the neuroconv metadata schema validation I opened catalystneuro/neuroconv#769, which fixed it for me when using this branch I know we've had issues/differences with the jsonschema python library on Mac - maybe mine is a Windows specific issue? |
Huh weird. Since this is the pattern used to check the validity of the value, we shouldn't receive any errors regarding the |
I might not have read the error from the popup window closely enough; only digging through the traceback led me to the source and the right message |
This works for me now |
Also, any way to write a test for this? |
This one is much more straightforward than the others. I'll start with this next week. |
Pydantic v2 issues causing CI failure should be fixed with the pin to pyinstaller hook contrib + catalystneuro/neuroconv#770 |
fix #634
There's some custom schema validation logic that wasn't referring to the correct schema. Fixed!