Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom schema validation #639

Merged
merged 9 commits into from
Mar 9, 2024
Merged

Conversation

garrettmflynn
Copy link
Member

fix #634

There's some custom schema validation logic that wasn't referring to the correct schema. Fixed!

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn This prevents the flag from raising on entry to the field, but I can't move past the file metadata page due to the same previous schema error

@garrettmflynn
Copy link
Member Author

Can you try again? This is working fine on my end.

Avoided a stray error in the Search component with the last push. May have something to do with what you observed

@CodyCBakerPhD
Copy link
Collaborator

Can you try again? This is working fine on my end.

I'm surprised; after digging into this it was coming from the neuroconv metadata schema validation

I opened catalystneuro/neuroconv#769, which fixed it for me when using this branch

I know we've had issues/differences with the jsonschema python library on Mac - maybe mine is a Windows specific issue?

@garrettmflynn
Copy link
Member Author

Huh weird. Since this is the pattern used to check the validity of the value, we shouldn't receive any errors regarding the enum field, though, right?

@CodyCBakerPhD
Copy link
Collaborator

we shouldn't receive any errors regarding the enum field, though, right?

I might not have read the error from the popup window closely enough; only digging through the traceback led me to the source and the right message

@CodyCBakerPhD
Copy link
Collaborator

This works for me now

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) March 8, 2024 22:57
@CodyCBakerPhD CodyCBakerPhD self-requested a review March 9, 2024 01:29
@CodyCBakerPhD
Copy link
Collaborator

Also, any way to write a test for this?

@CodyCBakerPhD CodyCBakerPhD self-requested a review March 9, 2024 01:41
@garrettmflynn
Copy link
Member Author

This one is much more straightforward than the others. I'll start with this next week.

@CodyCBakerPhD
Copy link
Collaborator

Pydantic v2 issues causing CI failure should be fixed with the pin to pyinstaller hook contrib + catalystneuro/neuroconv#770

Ref; pyinstaller/pyinstaller-hooks-contrib#610

@CodyCBakerPhD CodyCBakerPhD merged commit 1a86f2f into main Mar 9, 2024
15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix-custom-schema-validation branch March 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

species constraints inconsistent
2 participants