-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MicroManagerTiffImagingInterface #399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Yep, looks like; we def need them to be floats after rehydrating |
garrettmflynn
changed the base branch from
main
to
coerce-numbers-to-floats
September 28, 2023 20:59
@CodyCBakerPhD Just published that PR. Looks like it works! |
garrettmflynn
added
the
interface
Add support for a specific NeuroConv interface / converter
label
Sep 28, 2023
for more information, see https://pre-commit.ci
@garrettmflynn Oh no 😆 putting fix PR # in the header of the base PR caused this to auto close lol |
CodyCBakerPhD
approved these changes
Sep 29, 2023
Indeed works great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the MicroManagerTiffImagingInterface. The first pass through this interface, however, reveals an issue where JavaScript does not maintain float values with trailing zeros so the value of
imaging_rate
in JSON is20.0
(float), which gets converted to20
in JS (number) and passed back to Python as20
(int).Do we need to correct for int-like floats like we do for expected NaN values?
Error