Coerce All Numbers to Floats to Maintain Consistency Between JS, JSON Schema, and Python #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
| obj[key] = math.nan | ||
| obj[key] = math.nan # Turn None into NaN if a number is expected (JavaScript JSON.stringify turns NaN into None) | ||
| elif prop_schema.get("type") == "number" and isinstance(value, int): | ||
| obj[key] = float(value) # Turn integer into float if an integer is expected (JavaScript / JSON Schema coerces floats with trailing zeros to integers) |
There was a problem hiding this comment.
Should the comment be 'if a float is expected'?
Also is it possible to auto-detect from the presence of a . in the stringified number whether it ought to be float or int?
There was a problem hiding this comment.
Yes my bad. I'd written this before I looked up that number is equivalent to float in JSON Schema.
Theoretically yes—but that'd require us to roll our own JSON parser in addition to storing this information together with the parsed value (as JS has no way to differentiate 20 and 20.0) until it's re-stringified for storage / use by Python.
CodyCBakerPhD
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #399 and #400